[#9] Task CRUD API 스펙 정의 및 생성 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Aug 19, 2024
f-lab-lyan
reviewed
Aug 19, 2024
f-lab-lyan
reviewed
Aug 19, 2024
|
|
||
| @Test | ||
| void 조회할_Task가_존재하지_않는다면_실패응답메시지를_받는다() throws Exception { | ||
| mockMvc.perform(RestDocumentationRequestBuilders.get("/v1/tasks/{id}", 0) |
There was a problem hiding this comment.
mockMvc 와 testRestTemplate
There was a problem hiding this comment.
Tomcat Server에 대해서 잘 모르는것 같아 우선 정리하고, 두가지의 차이점을 알아본다음에 필요한 경우 수정해보겠습니다!
우선 PR이 오래 살아있는 것 같아 나누어서 다음 PR로 나누어서 올리겠습니다 😀
f-lab-lyan
reviewed
Sep 2, 2024
api/src/test/java/com/taskbuddy/api/controller/TestControllerTest.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Sep 2, 2024
|
|
||
| public record TaskCreateRequest( | ||
| String title, | ||
| String description, | ||
| TimeFrame timeFrame | ||
| ) {} | ||
| ) { |
There was a problem hiding this comment.
Spring Validation 의존성을 추가하기 전에 Request에 대한 Validation을 진행해야할 것 같아 Assert 를 추가한 유효성검증 로직을 추가하면서 생성자를 만들었습니다. Spring Validation Annotation을 붙이면 해당 생성자는 제거하려고 합니다!
|
전체적으로는 괜찮은 것 같습니다. mockMVC는 나중에 업데이트 하실 예정이신건가요? 그럼 이 PR은 머지해도 괜찮을 것 같네요. |
f-lab-lyan
approved these changes
Sep 2, 2024
|
넵 mockMvc 내용은 별도로 올리겠습니다! 리뷰 감사합니다 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 내용
jackson-datatype-jsr310dependency 추가java 8 date/time type 'java.time.localdatetime' not supported by default